Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45938 )
Change subject: lib and libpayload: add 64-bit versions of clz, __ffs and log2
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45938/1/src/include/lib.h
File src/include/lib.h:
https://review.coreboot.org/c/coreboot/+/45938/1/src/include/lib.h@59
PS1, Line 59: __builtin_clz
I guess I'd rather leave clz alone and just change this one.
Sorry, by "everywhere" I meant "on every architecture" (even though it's technically architecture-dependent whether int64_t is `long` or `long long`, but I think the latter should still work for both). Of course I was only talking about this function, the 32-bit clz() should still use the 32-bit builtin.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefc6e6c51f5b20607c88e38660a499a4f77ce0d0
Gerrit-Change-Number: 45938
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Oct 2020 20:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment