30 May
2019
30 May
'19
12:13 a.m.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32936 )
Change subject: mb/google/hatch: Create kindred variant ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32936/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/#/c/32936/3/src/mainboard/google/hatch/variants/... PS3, Line 51: device pci 15.0 on
Does this initial CL need to have all these devices? I think some/most of these wouldn't be the same […]
I followed the pattern that Kohaku used; copy from Hatch as-is, then make changes in the next CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09ad3da0505d599fc3797d7fa24b4dc170dcd18b
Gerrit-Change-Number: 32936
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 May 2019 21:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment