build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 64:
(14 comments)
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse_bp.c:
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 215: if(!cse_get_bp_entry(bp, &cse_bp)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 229: if(!cse_get_bp_entry(bp, &cse_bp)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 243: if(!cse_get_bp_entry(bp, &cse_bp)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 310: if(!cse_get_bp_entry(bp, &cse_bp)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 323: if(!cse_get_bp_entry(bp, &cse_bp)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 298: /* ME RW region is valid */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 299: ME_RW_VALID = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 299: ME_RW_VALID = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 301: /* ME RW Update is required */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 302: ME_RW_INVALID = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 302: ME_RW_INVALID = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 304: /* ME RW Signature is invalid */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 305: ME_RW_SIGN_INVALID = 2, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/64/src/soc/intel/common/block... PS64, Line 305: ME_RW_SIGN_INVALID = 2, please, no spaces at the start of a line