Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42522 )
Change subject: soc/amd/common: Drop ACPIMMIO GPIO bank separation ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42522/5/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42522/5/src/soc/amd/picasso/i2c.c@1... PS5, Line 196: gpio_read32(0); /* Flush posted write */
Is it worth coalescing the posted writes? Or just use gpio_write32_rb() for both?
I remember seeing some patch about disabling posted writes for some MMIO region, so need to check if this is needed anymore.
Also I don't like it that picasso forked copy of this function from stoneyridge only because i2c_2_gpi[] array is different, I have a [WIP] followup on this.