Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38165/4/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/38165/4/src/soc/intel/tigerlake/inc... PS4, Line 4: 2019 2019-2020. same for other files
https://review.coreboot.org/c/coreboot/+/38165/4/src/soc/intel/tigerlake/inc... PS4, Line 37: #define CAPID0_A 0xe4 : #define VTD_DISABLE (1 << 23) can we move common defines to the common header?