John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: ec/kontron: Fix control flow DEADCODE issue ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45623/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45623/5//COMMIT_MSG@11 PS5, Line 11: This change removes this DEADCODE.
This change makes Coverity happy by using an assertion instead.
Done
https://review.coreboot.org/c/coreboot/+/45623/5/src/ec/kontron/kempld/kempl... File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/45623/5/src/ec/kontron/kempld/kempl... PS5, Line 253: assert(prescale < 0);
Um, no. We want `prescale` to be larger than or equal to 0.
Done