6 Jan
2021
6 Jan
'21
8:21 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 38:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45398/38/src/soc/mediatek/mt8192/pm... File src/soc/mediatek/mt8192/pmif.c:
https://review.coreboot.org/c/coreboot/+/45398/38/src/soc/mediatek/mt8192/pm... PS38, Line 49: addr Is this expected to be less than (1 << 16)? If so, should we change the type to u16?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fc28f72d9522133baa06f9d67c383f814d862c
Gerrit-Change-Number: 45398
Gerrit-PatchSet: 38
Gerrit-Owner: CK HU ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Jan 2021 06:21:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment