Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37178 )
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37178/8/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37178/8/src/soc/amd/common/block/in...
PS8, Line 39: * in PMx24[1] (older implementations) and PMx04[1] (newer implementations).
PMx24[0] ?
The comment is wrong. According to RRGs bit 0 enables the blocks (default disable) and bit 1 configures the access mode (IO mapped - 1; or default memory mapped - 0). Will update it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa31abc3dbdf77d8513fa83c7415b9a1b7fd266f
Gerrit-Change-Number: 37178
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Dec 2019 15:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment