Attention is currently required from: Nico Huber, Subrata Banik, Arthur Heymans. Hello build bot (Jenkins), Nico Huber, Subrata Banik, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64076
to look at the new patch set (#2).
Change subject: src/soc/intel/cmn/fast-spi: Add SSDT extension to fast SPI driver ......................................................................
src/soc/intel/cmn/fast-spi: Add SSDT extension to fast SPI driver
If the SPI controller is hidden from the OS (which is default on Apollo Lake) then OS has no chance to probe the device and therefore can not be aware of the resources this PCI device occupies. If the OS needs to move some resources for a reason it can happen that the new allocated window will be shadowed by the hidden PCI device resource and hence causing a conflict. As a result this MMIO window will be inaccessible from the OS which will cause issues in applications. For instance on Apollo Lake this causes flashrom to stop working.
This patch adds a SSDT extension for the PCI device if it is hidden from the OS and reports the occupied resource via ACPI to the OS. Since there is no defined ACPI ID for the fast SPI controller available now, the generic one (PNP0C02) is used.
Test: Boot mc_apl4 and make sure flashrom works again.
Change-Id: Ia16dfe6e001188aad26418afe0f04c53ecfd56f1 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/soc/intel/common/block/fast_spi/fast_spi.c 1 file changed, 65 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/64076/2