[coreboot-gerrit] [S] Change in coreboot[main]: brya: Add support to get sku ID

[Subrata Banik (Code Review)]

Attention is currently required from: Aamir Bohra, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.

Subrata Banik has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86599?usp=email )

Change subject: brya: Add support to get sku ID
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> I am implementing the sku_id defined in https://github.com/coreboot/coreboot/blob/4985079b161f425137ee9e07ff86ddad1d...
>
> This gets used in setting the SKUID in coreboot table: https://github.com/coreboot/coreboot/blob/4985079b161f425137ee9e07ff86ddad1d...
>
> https://github.com/coreboot/coreboot/blob/4985079b161f425137ee9e07ff86ddad1d...
>
> Some of ARM based boards rely on the ADC pins for SKU ID information, the sku_id function allows to define underlying mechanism for reading SKU ID across different mainboards.

in that case, can you implement sku_id() inside cros_ec file itself so you don't need to implement per board basic ? and use some smart method to call into ADC PIN when CONFIG_SKUID_VIA_CHROMEEC vs CONFIG_SKUID_VIA_ADC_PIN.

In any case, you need a better commit msg, the current code doesn't convey what you are trying to achieve