Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46587 )
Change subject: lenovo/g505s: proper way of IRQ table programming ......................................................................
Patch Set 2:
(2 comments)
Thank you for working on this.
https://review.coreboot.org/c/coreboot/+/46587/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46587/2//COMMIT_MSG@7 PS2, Line 7: lenovo/g505s: proper way of IRQ table programming Please make it a statement by adding a verb in imperative mood:
Properly program the IRQ table
https://review.coreboot.org/c/coreboot/+/46587/2/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46587/2/src/mainboard/lenovo/g505s/... PS2, Line 95: **********************************************/ I’d remove the comment, as it does not add more information than deduced from the function name, and it does not follow the coding style.