Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45479 )
Change subject: soc/amd/picasso/acpi: add UART DMA controller devices
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45479/2/src/soc/amd/picasso/acpi/sb...
File src/soc/amd/picasso/acpi/sb_fch.asl:
https://review.coreboot.org/c/coreboot/+/45479/2/src/soc/amd/picasso/acpi/sb...
PS2, Line 102: Edge
Hrmm, is this still the case then? AFAIK we should not be sharing edge level interrupts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54c3f3d9b6806884366fdef131306c02d1142657
Gerrit-Change-Number: 45479
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 17 Sep 2020 15:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment