Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@7
PS1, Line 7: Remove ChromeOS EC support EHL smihandler
Remove ChromeOS EC support from smihandler
Done
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@9
PS1, Line 9: EHL
EHL CRB
Done
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@10
PS1, Line 10: codes
support
Done
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@11
PS1, Line 11:
In fact you are completely dropping smihandler.c instead of removing parts of it. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id474c3b04a82c03dda6514cc4565b58fb790b9c1
Gerrit-Change-Number: 48118
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 07:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment