John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40616 )
Change subject: mb/google/volteer: Include TCSS power management
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Can this go in southbridge.asl directly so it doesn't need to be added by each mainboard?
It might get confusion since tcss is not part of southbridge.
Tcss is located on northbridge, not PCH. It seems meaningful to include tcss inside northbridge.asl. Is it ok?
northbridge.asl is fine to me.
Sorry, I take it back as northbridge.asl is at src/soc/intel/common/block/acpi. It appears not a proper to include tcss.asl there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae31a29eb23f7370737d097dd401f4056b8b7052
Gerrit-Change-Number: 40616
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Apr 2020 03:29:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment