Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46437 )
Change subject: mb/volteer: New variant for Volteer reworked with Dauntless ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46437/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/46437/6/src/mainboard/google/voltee... PS6, Line 140: volteer2_ti50 Instead of copying the entire directory, can you still use the volteer2 directory and handle the differences using the Kconfigs? I think the only difference between these variants is going to be the TPM and the interface.
https://review.coreboot.org/c/coreboot/+/46437/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/46437/6/src/mainboard/google/voltee... PS6, Line 9: MAINBOARD_HAS_SPI_TPM_CR50 Rather than making each variant select, can this be done in Kconfig using "if BOARD_GOOGLE_VOLTEER2_TI50" and "if !BOARD_GOOGLE_VOLTEER2_TI50" to select the right config?