build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48163 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 8:
(15 comments)
File src/mainboard/lenovo/g505s/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/5dddf7e4_cc40b59e PS8, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/8f2baa3b_026773c1 PS8, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/2c7bb9c7_0231eb7f PS8, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/f0b2ab2c_fedff0af PS8, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/780baf59_933f59cc PS8, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/b0d31583_4c5fe69f PS8, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/8af182ba_5f25a36c PS8, Line 35: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/b3387f4b_35dee406 PS8, Line 37: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/f05ae0ea_6e7b6c42 PS8, Line 40: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/41afbe5b_c0b6b206 PS8, Line 43: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/d595d8fe_7c30f45a PS8, Line 46: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/855d4414_7ccf27fe PS8, Line 49: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/ae366c92_b3adf32f PS8, Line 51: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/100cea61_88091395 PS8, Line 53: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x2, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131797): https://review.coreboot.org/c/coreboot/+/48163/comment/0500ae91_64826193 PS8, Line 55: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90}, {0x01, 0xdc90} }, 0x3, 0x0} line over 96 characters