Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35303 )
Change subject: mb/google/drallion: Enable 360 sensor detection ......................................................................
Patch Set 18:
(7 comments)
Please remember to mark comments "done" when you're done, or we can't submit the change.
https://review.coreboot.org/c/coreboot/+/35303/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35303/2//COMMIT_MSG@10 PS2, Line 10:
add bug like this, BUG=b:140415892
Done
https://review.coreboot.org/c/coreboot/+/35303/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/chromeos.c:
https://review.coreboot.org/c/coreboot/+/35303/3/src/mainboard/google/dralli... PS3, Line 28: /* Sensor detection pin */ : #define SENSOR_DET_360 GPP_H5
Put this in gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/35303/3/src/mainboard/google/dralli... PS3, Line 134: gpio_input(SENSOR_DET_360);
I left comment in GPIO change CL.
Done
https://review.coreboot.org/c/coreboot/+/35303/6/src/mainboard/google/dralli... File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35303/6/src/mainboard/google/dralli... PS6, Line 61: #if CONFIG(BOARD_GOOGLE_DRALLION)
Use of __weak should be totally fine. […]
Done
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... PS7, Line 283: int
This can now be static. It is not used outside this file.
Done
https://review.coreboot.org/c/coreboot/+/35303/8/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/35303/8/src/soc/intel/cannonlake/in... PS8, Line 24: void variant_mainboard_memory_init_params(FSPM_UPD *mupd);
no need for that as you call it from mainboard_memory_init_params
Done
https://review.coreboot.org/c/coreboot/+/35303/7/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/35303/7/src/soc/intel/cannonlake/in... PS7, Line 24: void variant_mainboard_memory_init_params(FSPM_UPD *mupd);
Thanks for the guidelines, I have finished implementation.
Done