Please remember to mark comments "done" when you're done, or we can't submit the change.
7 comments:
add bug like this, BUG=b:140415892
Done
File src/mainboard/google/drallion/chromeos.c:
/* Sensor detection pin */
#define SENSOR_DET_360 GPP_H5
Put this in gpio. […]
Done
Patch Set #3, Line 134: gpio_input(SENSOR_DET_360);
I left comment in GPIO change CL.
Done
File src/mainboard/google/drallion/romstage.c:
Patch Set #6, Line 61: #if CONFIG(BOARD_GOOGLE_DRALLION)
Use of __weak should be totally fine. […]
Done
File src/mainboard/google/drallion/variants/drallion/gpio.c:
This can now be static. It is not used outside this file.
Done
File src/soc/intel/cannonlake/include/soc/romstage.h:
Patch Set #8, Line 24: void variant_mainboard_memory_init_params(FSPM_UPD *mupd);
no need for that as you call it from mainboard_memory_init_params
Done
File src/soc/intel/cannonlake/include/soc/romstage.h:
Patch Set #7, Line 24: void variant_mainboard_memory_init_params(FSPM_UPD *mupd);
Thanks for the guidelines, I have finished implementation.
Done
To view, visit change 35303. To unsubscribe, or for help writing mail filters, visit settings.