Attention is currently required from: Angel Pons, Branden Waldner, Paul Menzel.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41098?usp=email )
Change subject: mb/asus/p2b: Add ACPI support for p3b-f
......................................................................
Patch Set 14:
(2 comments)
File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/e7af35ab_31bc2aa0 :
PS14, Line 60: off
nit: Capitalise the 'o' for consistency
Acknowledged
https://review.coreboot.org/c/coreboot/+/41098/comment/a9da107a_738a3dbd :
PS14, Line 165: POST code
Not sure if we have something to print out POST codes from ACPI. […]
This is as optimal as it can be for ACPI code.
Gonna put this on hold while I finish current SNB/IVB work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3736532df0efde4399fb36eb19df8db511fac6ea
Gerrit-Change-Number: 41098
Gerrit-PatchSet: 14
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Branden Waldner
scruffy99@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Branden Waldner
scruffy99@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 14 Aug 2023 21:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
