Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46665 )
Change subject: sb/intel/lynxpoint: Ensure that `dev->chip_info` is not null ......................................................................
Patch Set 2:
(2 comments)
You may notice that I'm generally not convinced of the use of config_of(). I think it's really only useful for the let's-try-to-find-something-in-the-devtree-and-ignore-NULL style.
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... PS2, Line 144: config_t *config = config_of(dev); I guess that we didn't call this for PCH-H all the time proves that it's not needed to boot. So how about
if (!config) return;
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... PS2, Line 177: config_t *config = config_of(dev); Or guard the two statements that use it?