John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39785 )
Change subject: soc/intel/tigerlake: Configure TCSS xHCI power management ......................................................................
Patch Set 11:
(12 comments)
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 33: // Sub-command 0
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 34: // Sub-command 1
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 43: // Function number
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 44: // Device number
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 56: // 0x6C, General Purpose Event 0 Status [127:96]
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 58: // CPU WAKE STATUS
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 59: // 0x7C, General Purpose Event 0 Enable [127:96
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 61: // CPU WAKE EN
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi/tcss_xhci.asl:
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 22: // 0x74, XHCI CFG Power Control And Status
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 23: // 0x74 BIT[1:0]
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 25: // PME Enable
Use same comments style.
Done
https://review.coreboot.org/c/coreboot/+/39785/11/src/soc/intel/tigerlake/ac... PS11, Line 27: // PME Status
Use same comments style.
Done