Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )
Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Is somebody working on unifying the camera ASL code, so it’s automatically generated for example? For example, besides some values, the structure is very similar to.
src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@11
PS7, Line 11: BUG=None
No bug?
https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@14
PS7, Line 14: and able to capture image using world facing camera.
Did the camera work before?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Gerrit-Change-Number: 41173
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 16 Jun 2020 09:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment