Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83246?usp=email )
Change subject: mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings ......................................................................
mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings
Configuring USB2_PORT_EMPTY is equal to just not setting it. So remove it to clean up a bit.
Change-Id: I6854f4a0d3e7b51b242549556a5838d4183d3473 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 2 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83246/1
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index ca2e08b..10dcd6c 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -201,7 +201,6 @@ device ref south_xhci on register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC0), // Type-C Port1 - [1] = USB2_PORT_EMPTY, // M.2 WWAN [2] = USB2_PORT_MID(OC3), // M.2 Bluetooth [3] = USB2_PORT_MID(OC0), // USB3/2 Type A port1 [4] = USB2_PORT_MID(OC0), // Type-C Port2 diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index cfa8874..fafdbf9 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -205,14 +205,10 @@ device ref south_xhci on register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC3), // Type-C Port1 - [1] = USB2_PORT_EMPTY, // M.2 WWAN [2] = USB2_PORT_MID(OC0), // M.2 Bluetooth, USB3/2 Type A Port1 [3] = USB2_PORT_MID(OC3), // USB3/2 Type A Port 1 [4] = USB2_PORT_MID(OC3), // Type-C Port2 [5] = USB2_PORT_MID(OC3), // Type-C Port3 / MECC - [6] = USB2_PORT_EMPTY, // Not used - [7] = USB2_PORT_EMPTY, // Not used - [8] = USB2_PORT_EMPTY, // Not used [9] = USB2_PORT_MID(OC3), // CNVi/BT }"