Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu...
PS1, Line 25:
Also any power consumption concern?
I2C0 is only used in Grob360S for EMR function.
There are no i2c devices on I2C0 for rest fleex-related projects.
For power consumption, we will co-work with our HW team to measure it later.
There is no sku id for Grob360S yet.
I can configure it with sku ids if the Grob360S's sku id is determined.
More info for reference:
https://partnerissuetracker.corp.google.com/issues/135968368
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I784ff32418bc839bcec14fbfd7236f708828690e
Gerrit-Change-Number: 34364
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jul 2019 06:18:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment