[coreboot-gerrit] Change in ...coreboot[master]: stage_cache: Make empty inline function if CONFIG_NO_STAGE_CACHE enable

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33394 )

Change subject: stage_cache: Make empty inline function if CONFIG_NO_STAGE_CACHE enable
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/33394/7/src/include/stage_cache.h 
File src/include/stage_cache.h:

https://review.coreboot.org/#/c/33394/7/src/include/stage_cache.h@35 
PS7, Line 35: CONFIG(CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) \
            : 		|| CONFIG(RELOCATABLE_RAMSTAGE
> Humm okay. Makes sense.

yes furquan, i wish to do the same but you must watch those build failure. Looks like stage cache kconfig is in deep mess :(

Logically NO_STAGE_CACHE and other internal/external stage cache should be mutually exclusive but its not the case for many platform hence adding check based on NO_STAGE_CACHE cause redefinition of function.

I will clean stage_cache issue and create logic as per your suggestion here https://review.coreboot.org/c/coreboot/+/33116/7