Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44353 )
Change subject: soc/amd/common/espi_util: clarify espi_open_io_window ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44353/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44353/3//COMMIT_MSG@7 PS3, Line 7: slightly refactor espi_open_io_window
No need to change it, but I might've called it "clarify" vs. "slightly refactor". […]
The function that is being refactored is espi_open_io_window; espi_open_generic_io_window gets called by the function that is being refactored here. I replaced slightly refactor with clarify
https://review.coreboot.org/c/coreboot/+/44353/3//COMMIT_MSG@9 PS3, Line 9: If the espi_open_generic_io_window gets run
Haha, normally I feel like your written English is better than mine. […]
i reworded it a bit differently, but i'd still say that it is clearer in the new version
https://review.coreboot.org/c/coreboot/+/44353/3//COMMIT_MSG@10 PS3, Line 10: the if statement before
Nit, something like "the preceding if statement" might be more clear to the reader. […]
Done