Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
mb/intel/jasperlake_rvp: Remove sd card detect gpio
Tigerlake SoC doesn't have GPIO defined for GPP_G. so compilation is failing due to this.
We will update correct gpio for sd card detect once we have Jasper Lake soc gpio patch.
partner bug for tracking: https://ticket.coreboot.org/issues/251
BUG=None BRANCH=NONE TEST='jslrvp' mainboard builds successfully
Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38259 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb index 76ceb30..b4ed697 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb @@ -158,9 +158,6 @@ # Enable DPTF register "dptf_enable" = "1"
- # GPIO for SD card detect - register "sdcard_cd_gpio" = "GPP_G5" - # Enable S0ix register "s0ix_enable" = "0"