Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41908 )
Change subject: soc,southbridge/amd: Remove some explicit zero-initializers
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41908/2/src/southbridge/amd/cimx/sb...
File src/southbridge/amd/cimx/sb800/fadt.c:
https://review.coreboot.org/c/coreboot/+/41908/2/src/southbridge/amd/cimx/sb...
PS2, Line 68: }
Any plans to add one? if not, why clutter the file if it's unlikely to be
used in the future?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I263c159fe4b7757dd5abfc0d6248e45b749df980
Gerrit-Change-Number: 41908
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wrong ID - Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 09:05:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment