Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )
Change subject: mediatek/mt8183: Add SPI GPIO driving setting ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32460/5/src/soc/mediatek/mt8183/gpio.c File src/soc/mediatek/mt8183/gpio.c:
https://review.coreboot.org/#/c/32460/5/src/soc/mediatek/mt8183/gpio.c@135 PS5, Line 135: driving So this parameter is in milliamps now? Please just call it 'milliamps' or 'drive_milliamps' or something like that to make that clear.
https://review.coreboot.org/#/c/32460/5/src/soc/mediatek/mt8183/gpio.c@137 PS5, Line 137: if (driving < 2 || driving > 16) This should just be an assert()
https://review.coreboot.org/#/c/32460/5/src/soc/mediatek/mt8183/gpio.c@140 PS5, Line 140: if (bus == 0) Please use a switch-statement for 'bus'