7 Dec
2020
7 Dec
'20
12:29 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel: Move base addresses to Kconfig ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45610/17/src/northbridge/intel/hasw... File src/northbridge/intel/haswell/memmap.h:
https://review.coreboot.org/c/coreboot/+/45610/17/src/northbridge/intel/hasw... PS17, Line 10: CONFIG_FIXED_MCHBAR_ADDRESS
The '16 KB' comment was dropped..
It was wrong, MCHBAR on Haswell is actually 32 KiB. I guess the commit message should explain why it was dropped.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45610
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idca25b2e4bf65abcb3f8b150452ab2567baa60c3
Gerrit-Change-Number: 45610
Gerrit-PatchSet: 17
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Dec 2020 10:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com
Gerrit-MessageType: comment