Sindhoor Tilak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43131 )
Change subject: post_code: replace die postcodes with die_with_post_code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43131/1/src/lib/ramtest.c
File src/lib/ramtest.c:
https://review.coreboot.org/c/coreboot/+/43131/1/src/lib/ramtest.c@113
PS1, Line 113: printk(BIOS_DEBUG, "\nDRAM did _NOT_ verify!\n");
This changes behavior, doesn’t it? Should we die, if the test fails? If yes, the print line is not r […]
My bad, in this case it shouldn't have been replaced with a die. Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6188da11df046131eed1e77c41ae229852c2b5ac
Gerrit-Change-Number: 43131
Gerrit-PatchSet: 2
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 04 Jul 2020 08:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment