Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46312 )
Change subject: soc/intel/common: Boot time optimization
......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46312/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46312/4//COMMIT_MSG@7
PS4, Line 7: Boot time optimization
Please make it a statement by using a verb (in imperative mood).
Move CSE RW into new FMAP region to decrease boot time by 300 ms
https://review.coreboot.org/c/coreboot/+/46312/4//COMMIT_MSG@12
PS4, Line 12: impacts
increases the boot time by around 300 ms.
https://review.coreboot.org/c/coreboot/+/46312/4//COMMIT_MSG@28
PS4, Line 28: TEST=Verified on hatch and JSL platforms
What is the old boot time, and what is the new one?
https://review.coreboot.org/c/coreboot/+/46312/4//COMMIT_MSG@29
PS4, Line 29:
What commit does it fix? Please add a Fixes tag.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46312
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If043c9cb99fb822b62633591bf9c5bd75dfe8349
Gerrit-Change-Number: 46312
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 21:21:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment