Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27649 )
Change subject: mb/google/poppy/variants/nocturne: enable ec host event wake
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27649/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h:
https://review.coreboot.org/#/c/27649/1/src/mainboard/google/poppy/variants/...
PS1, Line 36: EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\
You also need to add EC_HOST_EVENT_MODE_CHANGE to SCI list.
Done
--
To view, visit
https://review.coreboot.org/27649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb
Gerrit-Change-Number: 27649
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Jul 2018 21:23:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No