Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, Julius Werner, mturney mturney. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support ......................................................................
Patch Set 37:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45206/comment/e1b1330a_2ac6f48a PS15, Line 8:
- Is this code copied? […]
Done
File payloads/libpayload/configs/config.herobrine:
https://review.coreboot.org/c/coreboot/+/45206/comment/5da9065f_c4625a0e PS6, Line 5: CONFIG_LP_SC7280_SERIAL_CONSOLE=y
Well, please don't add things in one patch here only to remove it in the next patch down the road ag […]
Done
File payloads/libpayload/drivers/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45206/comment/44bc54c3_b38464f8 PS22, Line 45: serial/sc7280.c
addressed this comment with below gerrit: […]
Done
https://review.coreboot.org/c/coreboot/+/45206/comment/abfeb963_ee30fa9c PS22, Line 45: serial/sc7280.c
addressed this comment with below gerrit: […]
Done
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/8f70e4c6_ddefdce1 PS6, Line 40: default 0xa
Ok, let's follow Julius' advice and not define these yet then.
Done
File src/mainboard/google/herobrine/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45206/comment/ec71f9d7_b1b08113 PS32, Line 3: bootblock-y += boardid.c
I believe that Julius brought up earlier that you can use `all-y += reset. […]
Done
File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/45206/comment/ee03355f_0c802521 PS32, Line 3: TROGDOR
HEROBRINE
Done
https://review.coreboot.org/c/coreboot/+/45206/comment/70771261_bb91c9e5 PS32, Line 4: TROGDOR
HEROBRINE
Done
https://review.coreboot.org/c/coreboot/+/45206/comment/185ffe45_0837ed25 PS32, Line 11: TROGDOR
HEROBRINE
Done