Attention is currently required from: Patrick Georgi, Angel Pons, Evgeny Zinoviev.
xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support
......................................................................
Patch Set 16:
(1 comment)
File src/mainboard/apple/macbookpro8_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33151/comment/b56f809e_25dcf135
PS8, Line 105: device pci 1a.7 on
Doesn't it show up in lspci? It looks like some USB controller device, but it's weird that it appear […]
this is the find_debugport for ft232h logging but the port is not the ones on the side. does anyone have the schematics to see if there is test points that one can tap into to access this? thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33151
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2
Gerrit-Change-Number: 33151
Gerrit-PatchSet: 16
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: xin hua wang
xinhuawang0101@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Mon, 20 Dec 2021 14:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Gerrit-MessageType: comment