Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39147 )
Change subject: soc/intel/{icl,tgl}: Make use of print_me_fw_version() from CSE lib
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39147/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39147/5//COMMIT_MSG@14
PS5, Line 14: TEST=Build and boot iclrvp, tglrvp boards.
Have you tested this? The 2 files added here will not even be compiled. They have to be included in a Makefile.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief75403c490eee499a84372e54fa38ea3016cc11
Gerrit-Change-Number: 39147
Gerrit-PatchSet: 5
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 19:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment