Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard: Add new Ivy Bridge board ASUS P8Z77-M
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38988/10/src/mainboard/asus/p8z77-m...
File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/10/src/mainboard/asus/p8z77-m...
PS10, Line 100: int
unsigned int
https://review.coreboot.org/c/coreboot/+/38988/10/src/mainboard/asus/p8z77-m...
PS10, Line 108: for (i = 0; i < max; i += 2)
Bootblock code space efficiency. […]
Difficult question how to optimize between code size and readability. Maybe add this as a separate commit, and keep it unmerged, until it’s clear that you need the 239 bytes?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If756e791ddce747cb1706414be8e41e83f88922b
Gerrit-Change-Number: 38988
Gerrit-PatchSet: 10
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 May 2020 09:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment