Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36045 )
Change subject: mb/g/drallion: Enable privacy screen on Drallion variant
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36045/7/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36045/7/src/mainboard/google/dralli...
PS7, Line 229: 0x0400
Yeah I agree that bit 31 should be set and I believe that bit 16 should be set as well. […]
Another thing, I currently see kernel complains with this when booting up:
[Firmware Bug]: ACPI(GFX0) defines _DOD but not _DOS
Do we need _DOS as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79d02bb1b25f0deb49ae4bb852b7ed8c21fd31c7
Gerrit-Change-Number: 36045
Gerrit-PatchSet: 7
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Fri, 18 Oct 2019 22:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rajat Jain
rajatja@google.com
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment