[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 17:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... 
File src/soc/intel/common/block/cpu/car/exit_car.S:

https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... 
PS17, Line 101: CONFIG_IA32_L3_MASK_1_DEFAULT
> It has I guess always seemed to work without reprogramming the L3_MASK anyways and logically what yo […]

Capturing next steps based on discussion:
1. Drop the code from exit_car.S (i.e. no need to add any new code)
2. Add a comment explaining why we are not configuring the masks to default on teardown
3. Perform tests as Tim requested.

Shreesh - does that make sense?