Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41989 )
Change subject: lp4x: Add new memory parts and generate SPDs
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41989/6/util/spd_tools/intel/lp4x/g...
File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41989/6/util/spd_tools/intel/lp4x/g...
PS6, Line 131: 1
It is a DDP and not a SDP. D2 indicates a DDP.
diesPerPackage as per JESD209-4C seems to be calculated differently. See: https://review.coreboot.org/c/coreboot/+/41612/19/util/spd_tools/intel/lp4x/...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7538247d39dfe5faab277d646f87f09103d6969
Gerrit-Change-Number: 41989
Gerrit-PatchSet: 8
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 17:35:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment