[coreboot-gerrit] Change in ...coreboot[master]: [WIP]arch/x86/postcar: Add x86_64 support

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )

Change subject: [WIP]arch/x86/postcar: Add x86_64 support
......................................................................

Patch Set 3:

(2 comments)

Do you think it's worth splitting x86_32 and x86_64 into separate files ?

https://review.coreboot.org/#/c/30500/3/src/arch/x86/gdt_init.S 
File src/arch/x86/gdt_init.S:

https://review.coreboot.org/#/c/30500/3/src/arch/x86/gdt_init.S@40 
PS3, Line 40: 	.align	4
> Is this enough for x86_64?

It's the same align as it was for x86_32.

https://review.coreboot.org/#/c/30500/3/src/arch/x86/gdt_init.S@42 
PS3, Line 42: 	/* selgdt 0, unused */
> Adding this is not x86_64 related change?

It is, as gdt moved the struct at gdtptr can no longer be used as dummy. It was a hack to save some memory on x86.