7 Sep
2018
7 Sep
'18
11:38 a.m.
Marx Wang has posted comments on this change. ( https://review.coreboot.org/28537 )
Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/28537/3/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/rammus/devicetree.cb:
https://review.coreboot.org/#/c/28537/3/src/mainboard/google/poppy/variants/... PS3, Line 296: GPP_D9_IRQ
Could you please help to check this pin setting in the gpio. […]
As I checked the schematics(GPP_D9/HP_IRQ_GPIO), we don't need to modify gpio.c. will double check the IRQ function after DA7219 driver is ready by using "evtest". Thanks.
--
To view, visit https://review.coreboot.org/28537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45
Gerrit-Change-Number: 28537
Gerrit-PatchSet: 3
Gerrit-Owner: Marx Wang marx.wang@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Marx Wang marx.wang@intel.com
Gerrit-Reviewer: YanRu Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Sep 2018 09:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No