Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )
Change subject: amd/common/block/spi: Add EFS SPI configurations to Kconfig
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s...
File src/soc/amd/common/block/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s...
PS17, Line 33: range 0 5
I explicitly specified it in both Mandolin and Zork rather than relying on the default to remove any […]
I'm planning on reworking the EM100 code. There are now two different versions that support different speeds. I'd ask that we go ahead and merget this for now, and I'll get it updated shortly. I can file a bug to do that and assign it to myself.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78558fa3fa27c70820f0f3d636544127adab6f8b
Gerrit-Change-Number: 42567
Gerrit-PatchSet: 17
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 20:57:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Matt Papageorge
matthewpapa07@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment