Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32300 )
Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32300/1/util/genbuild_h/genbuild_h.sh
File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/#/c/32300/1/util/genbuild_h/genbuild_h.sh@55
PS1, Line 55: util/crossgcc/xgcc/bin
Nit: This could be changed to ${XGCCPATH} - I can look at that in a future commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeedc22e0e14fa96b4f2a68127f405c7f0c9d5cc
Gerrit-Change-Number: 32300
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Apr 2019 16:35:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment