Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39837 )
Change subject: mb/emulation/qemu-q35: Enable CHROMEOS as an option ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG@15 PS1, Line 15: kernel driver with drm atomic support) but it does work with virtio. Sorry for being ignorant. What has the graphics init in coreboot to do with what Linux drivers are doing?
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG@19 PS1, Line 19: Please mention, that an FMAP is needed, and how you run QEMU with virtio.
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/chromeos.c:
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... PS1, Line 22: int get_write_protect_state(void) `bool is_write_protected(void)`
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... PS1, Line 31: int get_recovery_mode_switch(void) Make it return bool, and name it: `is_recovery_mode_enabled()?