Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40523 )
Change subject: soc/xeon_sp/skx: Define PPIN MSR
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40523/5/src/soc/intel/xeon_sp/skx/c...
File src/soc/intel/xeon_sp/skx/cpu.c:
https://review.coreboot.org/c/coreboot/+/40523/5/src/soc/intel/xeon_sp/skx/c...
PS5, Line 75: /* If socket_index is 0 then all PPIN have been saved. */
Makes sense, calling mp_run_on_aps() is more efficient. […]
Thanks for the info, I move the PPIN implementation to CB:40308
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e1de8bcb651fb8ae8b106db1978235b0dd84c47
Gerrit-Change-Number: 40523
Gerrit-PatchSet: 9
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Apr 2020 02:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Johnny Lin
Gerrit-MessageType: comment