Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39139 )
Change subject: drivers/intel/fsp2_0: Add force memory retraining ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 302: Cannt Cannot
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 324: printk(BIOS_ERR, "MRC_SPD_DATA at %p size=%ld\n", spd_cache, spd_cache_sz); Why error level?
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 328: jm: What does the prefix mean?
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 330: BIOS_INFO This should be error or warning level?