Attention is currently required from: Shelley Chen, Taniya Das, Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Make clock_configure() check for exact matches ......................................................................
Patch Set 6:
(2 comments)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/0a9a2548_33fc8e46 PS6, Line 104: die("Failed to find a matching clock frequency!\n"); You should print hz and the clk (rcg) pointer in this message so it's possible to understand what exactly it was trying to do that failed.
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/a95073e7_0365f7f3 PS6, Line 425: return clock_configure((struct clock_rcg *) Does this work? Note that this function never initializes mdss_clk_cfg.hz right now, I think it needs to to make the check match.