Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35725 )
Change subject: device/software_i2c: Add function to recover bus
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35725/1/src/device/software_i2c.c
File src/device/software_i2c.c:
https://review.coreboot.org/c/coreboot/+/35725/1/src/device/software_i2c.c@3...
PS1, Line 373: while (i++ < RECOVERY_CLK_CNT * 2) {
True... […]
sending random start conditions might also make some devices unhappy; what the kernel does here seems to be the best option that is least likely to cause some weird problems. if i read the code you suggested correctly (only had a brief look at it and the functions it calls), it should do the trick
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I264471e872cb353b28a6b71cc64a11aec59e63f2
Gerrit-Change-Number: 35725
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Sep 2019 20:19:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment