Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot tables: Add PCIe info to coreboot table ......................................................................
Patch Set 5:
(4 comments)
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/c82b3db5_0e7aaa81 PS4, Line 275: uint32_t Use uint64_t for address?
https://review.coreboot.org/c/coreboot/+/63251/comment/2bc0ac99_00c5ec62 PS4, Line 276: config_base I thought this is the same as `ctrl_base`, but it's not?
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/4cd78c3a_134a612f PS4, Line 87: struct { Can we use the cb_pcie struct (just like the 'framebuffer' field below)? Then cb_parse_pcie() could be simplified.
File src/include/boot/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/a3a4c803_6960c9cf PS2, Line 24: pcie
I think pcie is sufficient, new device may not support pci device anymore.
Ack